Remove dependency on atty and use std::io::IsTerminal instead#693
Merged
sharkdp merged 1 commit intosharkdp:masterfrom Oct 18, 2023
Merged
Remove dependency on atty and use std::io::IsTerminal instead#693sharkdp merged 1 commit intosharkdp:masterfrom
atty and use std::io::IsTerminal instead#693sharkdp merged 1 commit intosharkdp:masterfrom
Conversation
Owner
|
Thank you! |
jakelodwick
added a commit
to jakelodwick/hyperfine
that referenced
this pull request
Mar 14, 2026
The `statistical` crate hasn't been updated since 2019 and depends on `rand 0.6`, which pulls 25 transitive packages that duplicate hyperfine's existing `rand 0.8` stack. hyperfine uses three functions from `statistical`: `mean`, `median`, and `standard_deviation`. This replaces them with equivalent implementations in a new `util::stats` module (~20 lines). All existing tests pass without modification. Similar to sharkdp#693 which replaced `atty` with `std::io::IsTerminal`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the MSRV is now 1.70, the implementation from
stdcan be used instead.