fix: use cargo_bin! macro in integration tests (fixes #844)#875
Open
leno23 wants to merge 1 commit into
Open
Conversation
Replace deprecated Command::cargo_bin with assert_cmd::cargo_bin! so tests keep working with future Cargo versions. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
CI is green on all targets. Gentle ping when you have a moment — thanks! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces deprecated
Command::cargo_binfromassert_cmd::CommandCargoExtwithCommand::new(assert_cmd::cargo::cargo_bin!(\"hyperfine\"))intests/common.rs.The trait-based API is deprecated and will break when Cargo changes build directory layout (rust-lang/cargo#16147).
Test plan
cargo test --locked(39 integration tests pass)Fixes #844
Made with Cursor