fix: include parameter columns in CSV when using --reference (fixes #852)#877
Open
leno23 wants to merge 1 commit into
Open
fix: include parameter columns in CSV when using --reference (fixes #852)#877leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
When --reference is combined with parameter scans, the reference row has no parameters but was used to build the CSV header, causing a field-count mismatch on subsequent rows. Fixes sharkdp#852 Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
CI is green on all targets. Ready for review when convenient — thanks! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--referenceis combined with--parameter-scan/-L..first(), which may be the reference row with an empty parameter map).Test plan
cargo test --bin hyperfine test_csv test_csv_with_referencecargo clippy -- -D warningsCloses #852
Made with Cursor