Expose HYPERFINE_ITERATION to prepare and conclude commands#882
Open
c-tonneslan wants to merge 1 commit into
Open
Expose HYPERFINE_ITERATION to prepare and conclude commands#882c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
sharkdp#778 added the env var, but only set it on the actual benchmarked command, not on prepare or conclude. So this didn't work as you'd expect: hyperfine --prepare 'touch file${HYPERFINE_ITERATION}.dat' \ 'process file${HYPERFINE_ITERATION}.dat' \ --conclude 'rm file${HYPERFINE_ITERATION}.dat' In the prepare/conclude commands the variable was unset, so they all touched and removed 'file.dat'. The fix is to thread the same BenchmarkIteration through run_preparation_command and run_conclusion_command. Setup and cleanup keep NonBenchmarkRun since they only run once. Closes sharkdp#781 Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #781.
HYPERFINE_ITERATIONwas set only on the actual benchmarked command, so prepare/conclude saw an unset variable. The realistic use case in the issue (touch / process / rm files keyed by iteration) didn't work because every iteration's prepare and conclude saw the same empty value.The change threads the same
BenchmarkIterationthroughrun_preparation_commandandrun_conclusion_command. Setup and cleanup stay onNonBenchmarkRunsince they only run once per benchmark, not per iteration.Verified with:
which now prints prep / main / conc lines all reading
warmup-0, then0,1,2.Test in execution_order_tests covers warmup and the two benchmark iterations.