This repository was archived by the owner on Mar 30, 2019. It is now read-only.
Coreclr#651
Closed
manu-st wants to merge 20 commits intosharpdx:masterfrom
Closed
Conversation
added 20 commits
August 23, 2015 22:22
…rsion since we should use the one defined in SharpDX.PreSettings.targets.
…l be used to compile SharpFX against CoreCLR.
…HandleRef is not present in CoreCLR/CoreFX.
…is compiled by default using CoreCLR.
…evice.cs where we do not have access to the Winform Application class, so we cannot use it. We also add to define our own version of IMessageFilter, Keys and Message normally define in Winforms.
…on. This is while we find a solution for implementing them in CoreCLR if we need it one day.
…andle instead of SafeWaitHandle. Unfortunately the extension method is only available in .NET Framework 4.6 so we still have to keep the old way of accessing SafeWaitHandle.
…NET Framework and CoreCLR.
…andle instead of SafeWaitHandle. Unfortunately the extension method is only available in .NET Framework 4.6 so we still have to keep the old way of accessing SafeWaitHandle.
…or the time being we will assume that the argument is a valid handle of a Window in CoreCLR.
…own Is64BitProcess routine and are using it regardless of being running under the .NET Framework or CoreCLR.
…that are meaningful only when running under Winforms.
…and it might require hand modification to run against someone's checkout.
Member
|
Hi @manu-silicon Closing this issue as the PR #868 has partially solved the generation of compatible CoreCLR assemblies. There could be some remaining issues related to some API that could be used on CoreCLR but are not compatible. We can address them later if it is necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make it compile and run against CoreCLR