Conversation
- .NET SDK 9.0.100 → 10.0.201, TFM net9.0 → net10.0 across 48 projects - Avalonia 11.3.12 → 12.0.0 (core, Desktop, Themes.Fluent, DataGrid, Fonts.Inter) - Avalonia.AvaloniaEdit 11.0.0 → 12.0.0 - Avalonia.Diagnostics → AvaloniaUI.DiagnosticsSupport 2.2.0 - FluentAvaloniaUI 2.4.1 → 2.5.1 - TextBox.Watermark → PlaceholderText in 18 AXAML files - Remove DataAnnotationsValidationPlugin (removed in Avalonia 12) - Android: AvaloniaMainActivity<App> → AvaloniaMainActivity + AvaloniaAndroidApplication<App> - Clipboard: SetTextAsync → DataTransfer/DataTransferItem API - Markdown.Avalonia: IBinding → BindingBase, MathUtilities → Math.Abs - msix.yml framework: net9.0 → net10.0 - NUKE build TFM references updated Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59ac67ca70
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| /// <summary>Android application class for Avalonia 12 initialization.</summary> | ||
| [Application] | ||
| public class McpServerManagerApplication : AvaloniaAndroidApplication<App>; |
There was a problem hiding this comment.
Restore a valid Android application class definition
This line introduces McpServerManagerApplication as public class ...;, which is not a valid class declaration in C# and will fail when compiling the Android target (e.g., src/McpServerManager.Android). Even after fixing the syntax, this new [Application] type also conflicts with the existing [Application]-annotated MainApplication in MainApplication.cs, so Android startup config (cleartext/network security + crash diagnostics init) can be lost unless the app-class wiring is consolidated.
Useful? React with 👍 / 👎.
Summary
Test plan
dotnet build src/McpServerManager.Desktopcompiles cleandotnet build src/McpServer.Webcompiles cleandotnet build src/McpServer.Directorcompiles clean🤖 Generated with Claude Code