Cap dialog height to 90vh so tall content scrolls instead of overflows#4
Merged
SiteRelEnby merged 2 commits intomainfrom Apr 23, 2026
Merged
Cap dialog height to 90vh so tall content scrolls instead of overflows#4SiteRelEnby merged 2 commits intomainfrom
SiteRelEnby merged 2 commits intomainfrom
Conversation
Dialogs with many custom fields (e.g. member edit) could grow past the bottom of the viewport with no way to reach the save button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dialogs with many custom fields (e.g. the member edit dialog) could grow past the bottom of the viewport with no way to scroll to the save button.
Changes
max-h-[90vh] overflow-y-autoto the baseDialogContentcomponentTesting
ruff check sheaf/passescd web && npm run lint && npx tsc --noEmitpassesSecurity / privacy impact
None.
Screenshots