Skip to content

fix: Check hideshowvis-ignore-same-line before making overlay.#12

Merged
sheijk merged 1 commit intosheijk:masterfrom
eyal0:doit_first
May 27, 2024
Merged

fix: Check hideshowvis-ignore-same-line before making overlay.#12
sheijk merged 1 commit intosheijk:masterfrom
eyal0:doit_first

Conversation

@eyal0
Copy link
Copy Markdown
Contributor

@eyal0 eyal0 commented May 27, 2024

This fixes #11.

@eyal0
Copy link
Copy Markdown
Contributor Author

eyal0 commented May 27, 2024

This also greatly improves performance in my testing. Do many revert-buffer in a row and see how performance is maintained.

@Hi-Angel
Copy link
Copy Markdown

Just a small note: if you want the issue to get closed when the PR is merged, the syntax is:

Fixes: https://github.com/sheijk/hideshowvis/issues/11

Alternatively Closes keyword may be used. I don't think This fixes … as a line will work in this case.

@eyal0
Copy link
Copy Markdown
Contributor Author

eyal0 commented May 27, 2024

@Hi-Angel in my experience, the syntax that I used will work, too. In fact, on my phone, I can see a faint underline under the words "fixes" because GitHub has picked up this meaning.

Also, on the right side of the screen here, I see a note indicating that merging this PR may close the issue. (It says "may" because the owner, when merging this, can elect not to close the issue.)

Screenshot_20240527_162016_Firefox

I feel very confident that the syntax I used will work.

@sheijk sheijk merged commit 7b17424 into sheijk:master May 27, 2024
@sheijk
Copy link
Copy Markdown
Owner

sheijk commented May 27, 2024

@eyal0 good catch, thanks for the fix!

@eyal0 eyal0 deleted the doit_first branch May 27, 2024 23:36
@sheijk
Copy link
Copy Markdown
Owner

sheijk commented May 27, 2024

@eyal0 I'd also add you to the contributors list. If you want to just let me know what name I should put

@eyal0
Copy link
Copy Markdown
Contributor Author

eyal0 commented May 27, 2024

Took me embarrassingly long to figure out! My coding files reload a bunch due to git commands causing me to need to revert-buffer frequently and each one made a bunch of new overlays. I never noticed it in the profiler because those overlays are processed in c++ and not elisp, I think.

I did a bisect of my init file, commenting out lines, looking for a suspect. I then scanned through this code and, on a hunch, tried overlays-list. That got me the answer.

I am Eyal Soha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Leak in overlays when hideshowvis-ignore-same-line is t

3 participants