feat: add experimental shpool-vterm engine#311
Merged
ethanpailes merged 1 commit intomasterfrom Mar 3, 2026
Merged
Conversation
ethanpailes
changed the title
Contributor
Author
|
This is chained on #310 |
ethanpailes
force-pushed
the
integrate-with-shpool-vterm
branch
from
53dd43f to
86c9470
Compare
ethanpailes
force-pushed
the
integrate-with-shpool-vterm
branch
from
86c9470 to
33eac12
Compare
ethanpailes
force-pushed
the
integrate-with-shpool-vterm
branch
from
33eac12 to
1db970a
Compare
maxhbooth
approved these changes
Mar 3, 2026
This patch integrates the new shpool-vterm crate with shpool as a replacement for shpool_vt100. For now, this is opt in, and I expect it to be pretty broken in lots of ways that we'll find out as people start trying it out. By default, we still use the old shpool_vt100 crate. This is progress on #46
ethanpailes
force-pushed
the
integrate-with-shpool-vterm
branch
from
1db970a to
4cccb42
Compare
maxhbooth
reviewed
Mar 3, 2026
| /// mode session restoration. By default, this is Vt100, | ||
| /// but you can opt into the experimental Vterm engine | ||
| /// if you want to try it out. | ||
| pub session_restore_engine: Option<SessionRestoreEngine>, |
There was a problem hiding this comment.
Should we update the readme or something as well to let people know that this is an option? I'm not sure how you typically advertise new config values
Contributor
Author
There was a problem hiding this comment.
I was planning to test it out myself a bit first, then when it seems stable enough to be somewhat usable add an entry to the README for other testers. I don't want to tell people to try it out yet since I haven't even tried it myself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch integrates the new shpool-vterm crate with
shpool as a replacement for shpool_vt100. For now, this
is opt in, and I expect it to be pretty broken in lots
of ways that we'll find out as people start trying it
out.
By default, we still use the old shpool_vt100 crate.
This is progress on #46