Open
Conversation
This patch bumps the shpool_pty crate version to pick up some soundness fixes. I noticed that it's resource management was unsound when I realized that it both allowed cloning and did not use reference counting, so I fixed that. I think the only reason this wasn't burning us before was that the lifetime for the Fork object was outliving all the Master and Slave objects pulled off of it (either that or we were just not cleaning up resources at all).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link
I realized this was an issue while working on #348
AI Policy Ack
Ack, all meat coded.
Description
This patch bumps the shpool_pty crate version to pick up some soundness fixes. I noticed that it's resource management was unsound when I realized that it both allowed cloning and did not use reference counting, so I fixed that.
I think the only reason this wasn't burning us before was that the lifetime for the Fork object was outliving all the Master and Slave objects pulled off of it (either that or we were just not cleaning up resources at all).