publish: ship a game's preview pack as a second release asset#92
Merged
Conversation
When a game dir contains a preview/ authoring dir (preview.yaml + text frames), the build job now packs it into a preview.scp via the same pinned-kit kit() helper it uses for `check`, staging it next to the wasm. If the dir exists but packing fails (bad art, or the game's pinned kit predates `preview pack`), the job fails loudly rather than shipping a game without its art. Games with no preview/ dir are unchanged. The release job attaches preview.scp as a second asset, pins a `preview-digest: sha256:<hex>` line right after the wasm digest, and makes the release identity the PAIR (wasm digest, preview digest) so an art-only change cuts a new release. Absent preview compares as "", so releases with no preview keep today's semantics and an old release predating preview packing reads as changed once a preview appears. validate_game_dir.py now rejects a stray committed .scp (the packed output) as a build artifact; the preview/ sources still pass. The two-job secrets/game-code split and the game:publish notify are untouched. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishes each changed game's preview loop alongside its wasm (companion to shellcade/shellcade#218 and shellcade/kit#75):
games/<owner>/<game>/preview/exists, pack it via the game's own pinned kit (shellcade-kit preview pack) and stagepreview.scp. A preview dir that fails to pack — bad art, or a kit pin predating the subcommand — fails the job loudly rather than silently shipping without art. Games without the dir publish exactly as today.preview.scpas a second asset, pinspreview-digest: sha256:<hex>in the notes after the untouched wasmdigest:line, and extends the idempotency identity to the (wasm digest, preview digest) pair — an art-only change now cuts a release. The wasm-digest extraction is line-anchored so the two lines can't be confused regardless of order..scp(verified it previously slipped through — it's not .wasm, not executable, no native magic).actionlint clean (only the pre-existing SC2016 info note from main).
preview packships with the kit version games pin).preview/dirs (blackjack + salvo, blackjack, salvo: preview animation authoring sources #91) need their kit pins bumped to that release before their next publish, or the loud-failure path trips by design.🤖 Generated with Claude Code