fix: Installation don't stop, error but the service is failing. #4678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi, @slackjeff Thank you for the contribution! It makes totally sense to check if the service is up before continue it. I did notice that the commit message doesn’t quite follow our usual pattern. We like to stick to the Conventional Commit approach. Could you please update it when you get a chance? Thanks again. |
slackjeff
changed the title
Service normally starts, but after a few seconds it fails. The installer did not cause an error
Member
|
Thanks for the PR! This has been addressed in a separate commit, so I’m closing this one. Appreciate the effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service normally starts, but after a few seconds it fails. The installer did not cause an error