refactor(ui): migrate Admin Dashboard from Vuex to Pinia #4738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luannmoreira
added
area/ui
javascript
luannmoreira
added
status/ready-for-testing
status/under-testing
luannmoreira
force-pushed
the
refactor/admin-pinia-store
branch
3 times, most recently
from
1dd4053 to
41972ef
Compare
luannmoreira
force-pushed
the
refactor/admin-pinia-store
branch
2 times, most recently
from
1f0adc6 to
53734c2
Compare
Replaced entire Vuex store in the Admin Dashboard UI with Pinia. Structure and logic were remodeled to align with Pinia patterns. Note: Tests are not yet updated or implemented.
- Migrated all component and store unit tests from Vuex to Pinia:
- Updated Dashboard, NamespaceDetails, FirewallRulesDetails, DeviceDetails,
Login, and AnnouncementDetails view tests.
- Replaced Vuex `createStore` mocks with Pinia `createPinia` and store
instance mocks using `setActivePinia`.
- Adjusted mock store data assignments and method spies for Pinia stores.
- Fixed TypeScript type errors across unit tests:
- Corrected `firewallRules` mock objects by replacing `action: boolean`
with valid `action: string` values (e.g., "allow" or "deny").
- Fixed role types in `namespace.members` by using valid enum string
values ("owner", "administrator", etc.).
- Ensured `billing` property is explicitly typed as `undefined` instead
of `null` to match optional interface definitions.
- Declared mock objects using the correct `as` syntax or strongly typed
interfaces when needed to enforce type safety.
- Ensured all wrapper expectations and computed property tests reflect
updated store logic and structure.
- Maintained full snapshot coverage for migrated components.
These changes align all tests with the current Pinia store implementation
and eliminate type violations that were breaking the build.
luannmoreira
force-pushed
the
refactor/admin-pinia-store
branch
from
53734c2 to
12f57b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced entire Vuex store in the Admin Dashboard UI with Pinia.
Structure and logic were remodeled to align with Pinia patterns.
Note: Tests are not yet updated or implemented.