Skip to content

fix(ci): skip commit message check for dependabot push events#5931

Merged
otavio merged 1 commit intomasterfrom
fix/commit-check-dependabot-push
Mar 3, 2026
Merged

fix(ci): skip commit message check for dependabot push events#5931
otavio merged 1 commit intomasterfrom
fix/commit-check-dependabot-push

Conversation

@otavio
Copy link
Member

@otavio otavio commented Mar 3, 2026

Summary

  • The commit message check workflow fails on push events to master when dependabot commits are merged
  • The if condition used github.event.pull_request.user.login to detect dependabot, which is null on push events, so the check always ran
  • Replace with github.actor which is set for both push and PR events

Test plan

  • Verify the workflow still runs for normal commits on this PR
  • After merge, confirm the next dependabot push to master no longer triggers the check

The job-level condition used github.event.pull_request.user.login to
detect dependabot, which is null on push events. This caused the
commit message check to run and fail on dependabot merges to master
due to long lines in auto-generated commit bodies.

Replace with github.actor which is set for both push and PR events.
@otavio otavio requested a review from a team as a code owner March 3, 2026 16:27
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Claude finished @otavio's task in 4m 18s —— View job


Code Review Complete

Reviewed 1 file across code quality, security, testing, language patterns, and architecture — no issues found. The code looks good as-is.

The condition logic was verified against all trigger scenarios:

Scenario Result Correct?
push + dependabot[bot] actor Skipped Yes
push + human actor Runs Yes
pull_request + dependabot[bot] actor Skipped Yes
pull_request + human + non-draft Runs Yes
pull_request + human + draft Skipped Yes

Additional notes

The architecture review found that .github/workflows/qa.yml (line 14) uses the same fragile github.event.pull_request.draft == false pattern without an explicit push-event fallback. It works today because null == false evaluates to true in GitHub Actions expressions, but for consistency with this fix, it could be updated to:

if: ${{ github.event.pull_request.draft == false || github.event_name == 'push' }}

This is outside the scope of this PR and not blocking.

Also confirmed that cloud/.github/workflows/commit.yml already has the identical condition, so both repos will be in sync after this merges.


To request another review round, comment /review.

@otavio otavio merged commit 008f7b4 into master Mar 3, 2026
11 checks passed
@otavio otavio deleted the fix/commit-check-dependabot-push branch March 3, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant