Skip to content

fix(ui-react): fix connection announcement overflow in admin namespace details#6109

Merged
gustavosbarreto merged 1 commit intomasterfrom
fix/ui-react/admin-connection-announcement-responsiveness
Apr 6, 2026
Merged

fix(ui-react): fix connection announcement overflow in admin namespace details#6109
gustavosbarreto merged 1 commit intomasterfrom
fix/ui-react/admin-connection-announcement-responsiveness

Conversation

@luizhf42
Copy link
Copy Markdown
Member

@luizhf42 luizhf42 commented Apr 2, 2026

What

The connection announcement text in the admin namespace detail page now renders in a monospace <pre> block with horizontal scroll, preventing layout breakage at intermediate viewport widths.

Why

Long unbreakable strings (e.g., ***** separator lines, ASCII art) overflowed the settings card container between desktop and mobile breakpoints.

Changes

  • NamespaceDetails: wrapped connection announcement in a scrollable <pre> container with monospace font, matching the editing experience and preserving ASCII art formatting

…ness

Display the connection announcement text in a <pre> block with horizontal
scroll, so ASCII stuff renders correctly and can be properly viewed in
multiple viewports.
@luizhf42 luizhf42 requested a review from a team as a code owner April 2, 2026 17:18
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Claude finished @luizhf42's task in 1m 40s —— View job


Code Review Complete

Reviewed 1 file across code quality, security, testing, language patterns, and architecture — no issues found. The code looks good as-is.

The change correctly wraps the connection announcement in a scrollable <pre> container, preventing layout breakage from long unbreakable strings. React's JSX auto-escaping keeps it safe, and the approach is consistent with how connection_announcement is already displayed in Settings.tsx.


If you push additional changes and want a new review, tag @shellhub-io/admin and a team member can trigger it.

@gustavosbarreto gustavosbarreto merged commit 671531a into master Apr 6, 2026
13 checks passed
@gustavosbarreto gustavosbarreto deleted the fix/ui-react/admin-connection-announcement-responsiveness branch April 6, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants