fix(api): add id tiebreaker to paginated queries

[gustavosbarreto]

Problem

Paginated queries return rows in non-deterministic order when the primary sort column has duplicate values (e.g. multiple devices with the same last_seen), causing items to shift between pages.

Fix

Add id DESC as a secondary sort key to all paginated queries in Sort().

Fixes #6124

[github-actions]

Claude finished @gustavosbarreto's task in 3m 45s —— View job

---

Code Review Complete

Reviewed 1 file. 1 inline issue posted (1 critical).

The fix for deterministic pagination ordering is the right idea, but the hardcoded id DESC tiebreaker will break at runtime for tables that don't have an id column (api_keys, announcements). See the inline comment for details and suggested approaches.

---

To request another review round, comment /review.

[gustavosbarreto]

/review

[github-actions]

Claude finished @gustavosbarreto's task in 4m 58s —— View job

---

Code Review Complete

Reviewed 7 files. 2 inline issues posted (1 critical, 1 high).

The configurable tiebreaker approach is sound and addresses the original review feedback well. The Tiebreak field is correctly scoped (no query tag, service-layer only), backwards compatible with cloud callers, and the bun.Ident() usage is safe. Two issues need attention before merge:

1. api-key.go — tiebreak is dead code when sort_by isn't provided (missing default By)
2. Service tests — mock expectations across 5 test files need Tiebreak field added

---

To request another review round, comment /review.

[gustavosbarreto]

/review

[github-actions]

Claude finished @gustavosbarreto's task in 46s —— View job

---

Code Review Complete

Reviewed 12 files across code quality, security, testing, language patterns, and architecture — no issues found. The code looks good as-is.

The configurable Tiebreak approach is well-designed: backward-compatible with cloud callers (empty Tiebreak preserves existing behavior), safe from injection (bun.Ident() + no query struct tag), and correctly applied across all paginated call sites with appropriate tiebreak columns per table.

---

To request another review round, comment /review.

View job