fix(api): qualify column names in device queries with JOINs#6130
Merged
gustavosbarreto merged 1 commit intomasterfrom Apr 7, 2026
Merged
fix(api): qualify column names in device queries with JOINs#6130gustavosbarreto merged 1 commit intomasterfrom
gustavosbarreto merged 1 commit intomasterfrom
Conversation
Device queries that JOIN with namespaces produce ambiguous column references for columns present in both tables (e.g. "name"). Propagate CtxTableAlias through filters, sort, and status options so all column references are table-qualified.
|
Claude finished @gustavosbarreto's task in 3m 30s —— View job Code Review CompleteReviewed 3 files across code quality, security, testing, Go patterns, and architecture — no issues found. The code looks good as-is. The fix correctly follows the existing To request another review round, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
name), causingERROR: column reference "name" is ambiguous (SQLSTATE 42702)CtxTableAliasthrough filter, sort, and status query options so all column references are table-qualifiedCtxTableAliasto"device"inDeviceListandDeviceResolve, same pattern already used by sessions