fix(ui-react): fix sidebar behavior when terminal is open#6166
Merged
gustavosbarreto merged 3 commits intomasterfrom Apr 13, 2026
Merged
fix(ui-react): fix sidebar behavior when terminal is open#6166gustavosbarreto merged 3 commits intomasterfrom
gustavosbarreto merged 3 commits intomasterfrom
Conversation
Remove unnecessary pathname tracking logic, `useCallback` calls, and buggy `prevIsDesktop` check
…ning Add a `toggleDrawer` handler to the sidebar hook and pass it to `AppBar` and `AdminAppBar` via `onMenuToggle`
|
Claude finished @luizhf42's task in 3m 18s —— View job Code Review CompleteReviewed 6 files across code quality, security, testing, TypeScript/React patterns, and architecture — no issues found. The code looks good as-is. The approach of passing If you push additional changes and want a new review, tag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the sidebar behavior on desktop and mobile when a web terminal instance is open.
Why
The sidebar was presenting two strange behaviors when the terminal was open:
The fixes:
leftspace style based on it.z-index, making it appear above the terminal and be usable.Testing