fix(api): expose internal namespace lookup for SSH service#6228
Merged
gustavosbarreto merged 1 commit intomasterfrom Apr 22, 2026
Merged
fix(api): expose internal namespace lookup for SSH service#6228gustavosbarreto merged 1 commit intomasterfrom
gustavosbarreto merged 1 commit intomasterfrom
Conversation
Add GET /internal/namespaces/:tenant bound to the same handler but without the tenant guard, and point internalclient at it. The SSH service calls NamespaceLookup directly on api:8080 without the /auth subrequest, so the guard on /api/namespaces/:tenant was turning every SSH connection into a 403.
|
Claude finished @gustavosbarreto's task in 2m 17s —— View job Code Review CompleteReviewed 2 files across code quality, security, testing, language patterns, and architecture — no issues found. The code looks good as-is. Key observations:
To request another review round, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
GET /internal/namespaces/:tenantbound to the same handler as the public route but without the tenant guard, and pointinternalclient.NamespaceLookupat it.The SSH service calls
NamespaceLookupdirectly onapi:8080without passing through the nginx/authsubrequest, so theRequiresTenantguard added on/api/namespaces/:tenantin fe8e2bd was turning every SSH connection into a 403.Backported to
release/v0.21.6as 9881a99.