chore(ui): remove deprecated Vue frontend#6401
Conversation
|
Claude finished @luizhf42's task in 6m 52s —— View job Code Review CompleteReviewed 100 files across code quality, security, testing, language patterns, and architecture. 1 issue found (high severity). Additional notes
services := []Service{ServiceGateway, ServiceAPI, ServiceSSH, ServiceUI}
Fix: Remove // tests/environment/utils.go — remove line 23:
// ServiceUI Service = "ui"
// tests/environment/configurator.go:133 — change to:
services := []Service{ServiceGateway, ServiceAPI, ServiceSSH}If you've addressed the feedback and want a new review, tag |
d9906d0 to
3e14362
Compare
`ui-react` has reached parity and is ready to ship as the sole frontend, while the Vue `ui` app is fully stale and no longer developed. Remove the app and every external reference to the `ui` service: all compose files, the CI matrices in `qa.yml`, `docker-build.yml`, and `docker-publish.yml`, the `vue` lint/test modes in `devscripts`, and the `ui/` lines in `.dockerignore` and `CODEOWNERS`. The gateway now redirects `/v1/` to `/` with a `301` instead of proxying the old app, so old bookmarks land on `ui-react`. The `cloud` repo needs a matching change to drop its orphaned `ui` overrides.
3e14362 to
123d19a
Compare
Fixed. Removed the reference to the old UI service. |
|
/review |
|
Claude finished @gustavosbarreto's task in 5m 51s —— View job Code Review CompleteReviewed 100 files across code quality, security, testing, language patterns, and architecture — no issues found. The code looks good as-is. The removal is thorough and internally consistent: If you push additional changes and want a new review, tag |
|
/review |
What
Removes the unmaintained Vue
uiapplication and every reference to its Compose service across runtime routing, CI/CD, and developer tooling, leavingui-reactas the sole frontend.Why
ui-reacthas reached parity and is ready to ship as the only frontend, while the Vueuiapp is fully stale and no longer developed. Retiring it completes the migration and drops a second frontend that no longer earns its place in the build, CI, and gateway.Changes
/v1/now returns a301redirect to/instead of proxyingui:8080, so existing bookmarks of the old UI land onui-react. This was the only place routing production traffic to the old app.uiservice fromdocker-compose.yml,docker-compose.dev.yml, anddocker-compose.enterprise.yml, along with the gatewaydepends_on: uiand theui_node_modulesvolume.uifrom theqa.ymlmatrix, paths filter, and the six[UI]steps, and from thedocker-build.yml/docker-publish.ymlmatrices.shellhubio/uiis no longer built or published.vuemode fromlint-codeand theuicase fromtest-unit(plus its now-deadnpm_testhelper).ServiceUIhandle from the integration harness; the backend tests never consumed it andui-reactis still health-gated by the test stack.ui/entries from.dockerignoreandCODEOWNERS.Dependencies
Pairs with shellhub-io/cloud#2379, which removes the matching orphaned
uioverrides from the cloud Compose files. Merge the two together (or cloud first) — until then the enterprise/cloud dev stack fails Compose validation.Testing
./bin/docker-compose config -qvalidates for the base, dev, enterprise, and full enterprise/cloud stacks (the last with cloud#2379 checked out as the sibling repo); the merged render lists onlyui-react.curl -sI http://localhost/v1/returns301withLocation: /.shellhubio/uiimage before tagging a release, since it is no longer published.