Skip to content

chore: replace redis with valkey#6402

Merged
gustavosbarreto merged 1 commit into
masterfrom
chore/replace-redis-with-valkey
Jun 3, 2026
Merged

chore: replace redis with valkey#6402
gustavosbarreto merged 1 commit into
masterfrom
chore/replace-redis-with-valkey

Conversation

@gustavosbarreto
Copy link
Copy Markdown
Member

What

Swaps the Redis container image for Valkey across
the compose files and the asynq test containers.

Where Before After
docker-compose.yml redis valkey/valkey:8.1
docker-compose.enterprise.yml cache/redis cache/valkey/valkey:8.1
pkg/worker/asynq/{client,server}_test.go docker.io/redis:7 docker.io/valkey/valkey:8.1

Why

Redis moved to SSPL/RSALv2 in 2024 and AGPLv3 in 2025. Valkey is the
BSD-3 fork maintained by the Linux Foundation and is a drop-in
replacement: same RESP protocol, same clients.

No Go code changes. The go-redis/asynq clients, the redis:// URIs,
and the redis service name are kept as-is to minimize churn. The
testcontainers redis module boots the Valkey image fine since its wait
strategy matches Valkey's Ready to accept connections log line.

Note

The enterprise registry path cache/valkey/valkey assumes the
pull-through cache mirrors the upstream valkey/valkey image. Worth
confirming it resolves before merge.

@gustavosbarreto gustavosbarreto requested a review from a team as a code owner June 2, 2026 20:09
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Claude finished @gustavosbarreto's task in 4m 2s —— View job


Code Review Complete

Reviewed 4 files across code quality, security, testing, Go patterns, and architecture — no issues found. The change is a clean, consistent swap of Redis container images to Valkey 8.1 across all relevant locations:

  • docker-compose.yml — image and server command updated correctly
  • docker-compose.enterprise.yml — mirrors the upstream valkey/valkey namespace through the pull-through cache
  • Test containers in pkg/worker/asynq/ — both updated to match

Cross-repo check confirmed the cloud repo's compose files don't define their own redis service (they overlay the base), so no changes needed there. No stale redis-server or docker.io/redis references remain anywhere in the codebase.


To request another review round, comment /review.

Swap the Redis image for Valkey, the BSD-licensed Linux Foundation
fork, to avoid Redis's SSPL/AGPL relicensing. Valkey speaks the same
RESP protocol, so the go-redis and asynq clients, the redis:// URIs,
and the service name are left unchanged. Test containers in the asynq
package now boot Valkey as well.
@gustavosbarreto gustavosbarreto force-pushed the chore/replace-redis-with-valkey branch from 9257ef4 to 41a3ad3 Compare June 2, 2026 20:18
@gustavosbarreto gustavosbarreto enabled auto-merge (rebase) June 2, 2026 20:28
@gustavosbarreto gustavosbarreto disabled auto-merge June 3, 2026 17:17
@gustavosbarreto gustavosbarreto merged commit f6b2960 into master Jun 3, 2026
11 checks passed
@gustavosbarreto gustavosbarreto deleted the chore/replace-redis-with-valkey branch June 3, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant