chore: replace redis with valkey#6402
Merged
Merged
Conversation
|
Claude finished @gustavosbarreto's task in 4m 2s —— View job Code Review CompleteReviewed 4 files across code quality, security, testing, Go patterns, and architecture — no issues found. The change is a clean, consistent swap of Redis container images to Valkey 8.1 across all relevant locations:
Cross-repo check confirmed the cloud repo's compose files don't define their own To request another review round, comment |
Swap the Redis image for Valkey, the BSD-licensed Linux Foundation fork, to avoid Redis's SSPL/AGPL relicensing. Valkey speaks the same RESP protocol, so the go-redis and asynq clients, the redis:// URIs, and the service name are left unchanged. Test containers in the asynq package now boot Valkey as well.
9257ef4 to
41a3ad3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Swaps the Redis container image for Valkey across
the compose files and the asynq test containers.
docker-compose.ymlredisvalkey/valkey:8.1docker-compose.enterprise.ymlcache/rediscache/valkey/valkey:8.1pkg/worker/asynq/{client,server}_test.godocker.io/redis:7docker.io/valkey/valkey:8.1Why
Redis moved to SSPL/RSALv2 in 2024 and AGPLv3 in 2025. Valkey is the
BSD-3 fork maintained by the Linux Foundation and is a drop-in
replacement: same RESP protocol, same clients.
No Go code changes. The
go-redis/asynqclients, theredis://URIs,and the
redisservice name are kept as-is to minimize churn. Thetestcontainers
redismodule boots the Valkey image fine since its waitstrategy matches Valkey's
Ready to accept connectionslog line.Note
The enterprise registry path
cache/valkey/valkeyassumes thepull-through cache mirrors the upstream
valkey/valkeyimage. Worthconfirming it resolves before merge.