fix(jsx-email): add link href to vml for outlook buttons#274
Conversation
There was a problem hiding this comment.
I don't know how to actually run this locally to send a real email out to see how it turns out but based on my manual experiments messing around with the output on my existing codebase that does have email sending hooked up, something like this should work.
|
Hi @osdiab, Thank you for this PR—it helped me identify an oversight related to the href prop in the VML button implementation. The current VML button is based on the bullet proof email button by Stigm <v:roundrect href={href} ...>Would you like to address this in your PR, or should I go ahead and make the necessary changes? Looking forward to your thoughts! |
Component / Package Name:
This PR contains:
Are tests included?
Breaking Changes?
If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
resolves #272
Description
Something like this should fix that issue. based off of what I found from this random tutorial online. https://www.nobledesktop.com/learn/html-email/bulletproof-buttons-in-outlook