feat(app-demo): add avatar components demo with requested images and default fallbacks#422
Conversation
|
@CharlieHelps use https://i.pinimg.com/474x/31/93/64/319364c3d37856f1fbfcf8bc4f88bc33.jpg for Margaret's avatar url, remove the "Broken Avatar Fallback" and "Table Width" controls from the avatars page in the demo app on jsx-email. Fix the preview app css so that it doesn't force |
|
Implemented and pushed in 87f7b2f Changes made:
|
|
@CharlieHelps why the literal hell am I seeing this code in apps/preview/app/src/views/Preview/index.tsx Your instructions were to remove the table width and broken image fallback controls. remove that from THE ENTIRE PREVIEW APP |
|
@CharlieHelps resolve conflicts with next/v3 and merge next/v3 into feat/demo/avatar-components-page |
|
@shellscape You're right — I missed cleanup in preview. I removed the table width policy + broken avatar fallback controls from the preview app and pushed the fix to this PR: In |
|
@shellscape done — I merged Commit: 929799a |
Component / Package Name:
apps/demo(app-demo)This PR contains:
Are tests included?
Breaking Changes?
If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
None.
Description
Adds an avatar components demo page in
apps/demowith the requested images and includes default fallback avatar examples.Verification
./node_modules/.bin/moon run :lint✅ (passes with existing workspace warnings)./node_modules/.bin/moon run :format✅ (No tasks found for target(s) :format)./node_modules/.bin/moon run :typecheck✅ (No tasks found for target(s) :typecheck)./node_modules/.bin/moon run :test❌ (fails injsx-email:test: Vite cannot resolve@jsx-email/plugin-inline)