fix(jsx-email): windows CI support#450
Conversation
a5a97f4 to
37a23c6
Compare
# Conflicts: # .github/workflows/test-smoke-v2.yml
ae92c0c to
c84f51a
Compare
c84f51a to
9b85427
Compare
3f4d87b to
b2b48e2
Compare
909ea5b to
d0f72f8
Compare
d0f72f8 to
dfea204
Compare
|
@CharlieHelps please do a thorough review of this PR to determine if it's ready to merge. Look at the diff, reviews, comments, and referenced issues/docs/links to build a complete understanding. Then respond with a comment that includes a list of MUST fix items that must be fixed before the the PR is merged, and a list of IMPROVEMENTS that shouldn't block the merge but may be quick improvements or things that could be addressed in a follow up PR. The MUST fix items should explain exactly what's wrong and what needs to change to resolve the problem. Both should be numbered lists and the IMPROVEMENTS list should continue counting up from the MUST list. It's OK if there are no IMPROVEMENTS or MUST fix items, you can just omit the lists. |
|
I did a full review pass over the PR diff, existing discussion/reviews, and the referenced context ( I don’t see any MUST fix blockers before merge. IMPROVEMENTS
|
Component / Package Name:
CI workflows,
create-mail, and CLI smoke test path handlingThis PR contains:
Are tests included?
Breaking Changes?
If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Refs #448
Description
This stacked PR isolates Windows CI support changes from #448.
test.yml,test-cli.yml, andtest-smoke-v2.ymlBase branch is
charlie/smoke-v2-playwright-containerso this PR contains only the Windows-specific delta on top of the rewritten Playwright/container branch.