Skip to content

chore: remove ts in favor of @types/webpack-plugin-serve #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shellscape merged 4 commits into from
Mar 26, 2019
Merged

chore: remove ts in favor of @types/webpack-plugin-serve #119

shellscape merged 4 commits into from
Mar 26, 2019

Conversation

@matheus1lva
Copy link
Collaborator

@matheus1lva matheus1lva commented Mar 25, 2019 •
edited
Loading

This PR contains:

  • bugfix
  • feature
  • refactor
  • tests
  • documentation
  • metadata

Breaking Changes?

  • yes
  • [] no

If yes, please describe the breakage.

I suppose so? We removed types from the package and added them into an external one.

Please Describe Your Changes

Package install size was increasing a lot due to some packages external types were installing. In order to reduce that, i've extracted them into the DefinetelyTyped repo, where whoever needs them can install separately.

https://www.npmjs.com/package/@types/webpack-plugin-serve

@matheus1lva matheus1lva requested a review from shellscape March 25, 2019 17:04
@matheus1lva matheus1lva changed the title chore: remove ts in favor of @types chore: remove ts in favor of @types/webpack-plugin-serve Mar 25, 2019
@shellscape shellscape merged commit 0368773 into master Mar 26, 2019
@shellscape shellscape deleted the remove-ts branch March 26, 2019 13:59
@shellscape
Copy link
Owner

shellscape commented Mar 26, 2019

One thing I'm not sure about is whether or not this is a breaking change. For TypeScript users, yes. For the rest of the ecosystem, no.

@matheus1lva
Copy link
Collaborator Author

matheus1lva commented Mar 26, 2019

Yeah, i have the same doubt!

smashercosmo pushed a commit to smashercosmo/webpack-plugin-serve that referenced this pull request Jul 23, 2019
@matheus1lva @smashercosmo
chore: remove ts in favor of @types/webpack-plugin-serve (shellscape#119
c96e7bb 
)

* chore: remove ts from project

* docs: add types package name

* chore: tweak code fences in typescript readme section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shellscape shellscape Awaiting requested review from shellscape

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matheus1lva @shellscape