Add support for codex.tool_decision event mapping#242
Conversation
The mapEventName() function was missing a case for "codex.tool_decision", causing these events to pass through unmapped. The server then rejected them with "skipping event with invalid type" because it expects the flat "tool_decision" format, not "codex.tool_decision". https://claude.ai/code/session_01GGSxiNwFb739Q6NXPdhVJ2
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary of ChangesHello @AnnatarHe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the OpenTelemetry processor by enabling it to recognize and process Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully adds support for mapping the codex.tool_decision event type to model.AICodeEventToolDecision in the OTEL processor. The changes are consistent with the existing codebase patterns, and a corresponding test case has been added to ensure correct functionality. The implementation is straightforward and appears correct.
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Added support for mapping the
codex.tool_decisionevent type to the correspondingAICodeEventToolDecisionmodel constant in the OTEL processor.Changes
"codex.tool_decision"event inmapEventName()function that returnsmodel.AICodeEventToolDecisionDetails
This change enables the OTEL processor to properly recognize and map tool decision events from the Codex system, allowing these events to be tracked and processed alongside other AI code events. The implementation follows the existing pattern used for other event types in the codebase.
https://claude.ai/code/session_01GGSxiNwFb739Q6NXPdhVJ2