Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in AGENTS.md and README.md to better reflect the ShellTime CLI and daemon's functionality, including new sections on project identity, expanded command references, and updated setup instructions. The guidelines were also updated with more specific development and testing commands. A review comment pointed out that the specified Go version 1.26 is invalid and should be corrected to a stable version like 1.23.
| - `mockery`: regenerate mocks when interfaces change | ||
| - `pp g`: regenerate PromptPal-generated artifacts when relevant | ||
|
|
||
| Use Go 1.26, as declared in `go.mod`. |
| | `shelltime q "prompt"` | Alias for `shelltime query` | | ||
| | `shelltime cc install` | Install Claude Code OTEL shell configuration | | ||
| | `shelltime cc uninstall` | Remove Claude Code OTEL shell configuration | | ||
| | `shelltime cc statusline` | Emit statusline JSON for Claude Code | |
There was a problem hiding this comment.
🟡 README describes cc statusline output as JSON when it actually emits formatted ANSI text
The command table says shelltime cc statusline will "Emit statusline JSON for Claude Code", but the command actually reads JSON from stdin and outputs formatted plain text with ANSI color codes and OSC8 hyperlinks (see commands/cc_statusline.go:108 where fmt.Println(output) prints the result of formatStatuslineOutput, which returns a strings.Join(parts, " | ") of color-formatted segments). The command's own Usage field correctly says "Output statusline for Claude Code (reads JSON from stdin)" at commands/cc_statusline.go:28. A user reading this table entry would expect the command to produce JSON output, which is incorrect.
| | `shelltime cc statusline` | Emit statusline JSON for Claude Code | | |
| | `shelltime cc statusline` | Output formatted statusline for Claude Code | |
Was this helpful? React with 👍 or 👎 to provide feedback.
Summary
Why
The top-level docs were stale and no longer matched the current command set, setup flow, or contributor expectations.
Impact
Users get an accurate getting-started guide, and contributors/agents get clearer repo guidance for future doc and command updates.
Validation