Skip to content

Update GitHub organization from malamtime to shelltime #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnnatarHe merged 1 commit into from
Apr 17, 2026
+5 −8
Merged

Update GitHub organization from malamtime to shelltime #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions install.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ fi

if [ "$BREW_INSTALLED" = false ]; then

CLI_FILE_NAME="https://github.com/malamtime/cli/releases/latest/download/cli_"
CLI_FILE_NAME="https://github.com/shelltime/cli/releases/latest/download/cli_"
DAEMON_FILE_NAME="${CLI_FILE_NAME}daemon_"

cd /tmp
Expand Down Expand Up @@ -143,10 +143,7 @@ fi
if [[ "$OS" == "Darwin" ]] || [[ "$OS" == "Linux" ]]; then
mv shelltime "$HOME/.shelltime/bin/"
if [ -f "shelltime-daemon" ]; then
if [ -f "$HOME/.shelltime/bin/shelltime-daemon.bak" ]; then
rm "$HOME/.shelltime/bin/shelltime-daemon.bak"
fi
mv shelltime-daemon "$HOME/.shelltime/bin/shelltime-daemon.bak"
mv shelltime-daemon "$HOME/.shelltime/bin/"
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The mv command for the daemon binary does not handle potential failures. If the move operation fails—for instance, due to insufficient permissions or the daemon process being currently active ('Text file busy')—the installation will proceed as if successful, leaving the daemon unupdated or missing. Adding a simple error check or warning would improve the robustness of the installer, especially since the previous logic included more explicit handling (even if it was flawed).

Suggested change
mv shelltime-daemon "$HOME/.shelltime/bin/"
mv shelltime-daemon "$HOME/.shelltime/bin/" || echo "Warning: Failed to install shelltime-daemon."

fi
# elif [[ "$OS" == "MINGW64_NT" ]] || [[ "$OS" == "MSYS_NT" ]] || [[ "$OS" == "CYGWIN_NT" ]]; then
# mv shelltime /c/Windows/System32/
Expand Down Expand Up @@ -268,14 +265,14 @@ check_and_delete_bak "zsh.zsh"
check_and_delete_bak "fish.fish"

# Process zsh.zsh
process_file "zsh.zsh" "https://raw.githubusercontent.com/malamtime/installation/master/hooks/zsh.zsh"
process_file "zsh.zsh" "https://raw.githubusercontent.com/shelltime/installation/master/hooks/zsh.zsh"

# Process fish.fish
process_file "fish.fish" "https://raw.githubusercontent.com/malamtime/installation/master/hooks/fish.fish"
process_file "fish.fish" "https://raw.githubusercontent.com/shelltime/installation/master/hooks/fish.fish"

# Process bash.bash
process_file "bash-preexec.sh" "https://raw.githubusercontent.com/rcaloras/bash-preexec/master/bash-preexec.sh"
process_file "bash.bash" "https://raw.githubusercontent.com/malamtime/installation/master/hooks/bash.bash"
process_file "bash.bash" "https://raw.githubusercontent.com/shelltime/installation/master/hooks/bash.bash"

# Add source lines to config files
if [ -f "$HOME/.zshrc" ]; then
Expand Down
Loading