Refactor imports for lazy loading and implement XSS protection in HTML exporter#58
Refactor imports for lazy loading and implement XSS protection in HTML exporter#58shenald-dev wants to merge 1 commit into
Conversation
…L exporter - Moved heavy module imports (`networkx`, analyzers, visualizations) inside the `analyze` CLI command to reduce global scope loading overhead and improve startup times. - Moved nested analyzer imports (`bisect`, `json`) to module top level to eliminate per-call execution cost. - Implemented `html.escape` throughout `codedna/visualization/html_export.py` to sanitize dynamic repository data, fixing a potential Cross-Site Scripting (XSS) vulnerability. - Updated `test_visualization.py` assertions to align with HTML escaping logic. Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
APEX FORGE Run Report
What Changed
rich,networkx, and multiple analyzers) insidecli.pyto only load when executing theanalyzecommand.json,bisect) out of methods inSecurityDetectorandCodeSmellDetectorto their module level.HTMLExporterusinghtml.escape().Why It Matters
helpmenu and basic command parser do not unnecessarily trigger slow imports.Measurements Taken
time codedna --help) was validated.import networkxandimport richcaused hundreds of milliseconds of overhead. Post-refactoring, invocation is immediate.Checks Run
ruff check --fix .).pytest, including patched vulnerability paths.Repository Readiness
Remaining Risks
PR created automatically by Jules for task 13528463809812656413 started by @shenald-dev