Skip to content

fix(watcher): escape exception strings to prevent rich MarkupError crashes#92

Merged
shenald-dev merged 1 commit intomainfrom
fix/rich-markup-crash-421824631507001611
Apr 26, 2026
Merged

fix(watcher): escape exception strings to prevent rich MarkupError crashes#92
shenald-dev merged 1 commit intomainfrom
fix/rich-markup-crash-421824631507001611

Conversation

@shenald-dev
Copy link
Copy Markdown
Owner

Replaced console.print(f"[bold red]Error executing command: {e}[/bold red]") with console.print(f"[bold red]Error executing command: {escape(str(e))}[/bold red]") in src/echo/watcher.py. This ensures arbitrary exception strings containing [] brackets are safely escaped, preventing the thread from crashing via rich.errors.MarkupError. Also updated the test suite with a mock exception to reliably verify the fix.


PR created automatically by Jules for task 421824631507001611 started by @shenald-dev

…ashes

Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@shenald-dev shenald-dev added the bug Something isn't working label Apr 26, 2026
@shenald-dev
Copy link
Copy Markdown
Owner Author

PR looks good; the fix is minimal and well-tested. Ensure that escape is imported from rich in watcher.py (it appears to be).

Reviewed — quality: high

@shenald-dev
Copy link
Copy Markdown
Owner Author

Looks good, merging this in. CI is green and everything checks out 👍

Escapes exception strings in rich markup to prevent MarkupError crashes.

@shenald-dev shenald-dev merged commit 6aab926 into main Apr 26, 2026
1 check passed
@google-labs-jules
Copy link
Copy Markdown
Contributor

PR looks good; the fix is minimal and well-tested. Ensure that escape is imported from rich in watcher.py (it appears to be).

Reviewed — quality: high

Thank you for the review. I confirm that escape is imported from rich.markup at the top of src/echo/watcher.py.

@google-labs-jules
Copy link
Copy Markdown
Contributor

Looks good, merging this in. CI is green and everything checks out 👍

Escapes exception strings in rich markup to prevent MarkupError crashes.

Great, thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant