fix(watcher): escape exception strings to prevent rich MarkupError crashes#92
Conversation
…ashes Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
PR looks good; the fix is minimal and well-tested. Ensure that Reviewed — quality: high |
|
Looks good, merging this in. CI is green and everything checks out 👍 Escapes exception strings in rich markup to prevent MarkupError crashes. |
Thank you for the review. I confirm that |
Great, thanks for merging! |
Replaced
console.print(f"[bold red]Error executing command: {e}[/bold red]")withconsole.print(f"[bold red]Error executing command: {escape(str(e))}[/bold red]")insrc/echo/watcher.py. This ensures arbitrary exception strings containing[]brackets are safely escaped, preventing the thread from crashing viarich.errors.MarkupError. Also updated the test suite with a mock exception to reliably verify the fix.PR created automatically by Jules for task 421824631507001611 started by @shenald-dev