Skip to content

Fixes arrow scrolling behavior when mouse hovers component. Fixes #809. #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
detinho wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes arrow scrolling behavior when mouse hovers component. Fixes #809. #852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/pointerMixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ export default {
data () {
return {
pointer: 0,
pointerDirty: false
pointerDirty: false,
savedPointer: null
}
},
props: {
Expand Down Expand Up @@ -69,8 +70,10 @@ export default {
/* istanbul ignore else */
if (this.pointer < this.filteredOptions.length - 1) {
this.pointer++
this.savedPointer = null
/* istanbul ignore next */
if (this.$refs.list.scrollTop <= this.pointerPosition - (this.visibleElements - 1) * this.optionHeight) {
this.savedPointer = this.pointer
this.$refs.list.scrollTop = this.pointerPosition - (this.visibleElements - 1) * this.optionHeight
}
/* istanbul ignore else */
Expand All @@ -85,8 +88,10 @@ export default {
pointerBackward () {
if (this.pointer > 0) {
this.pointer--
this.savedPointer = null
/* istanbul ignore else */
if (this.$refs.list.scrollTop >= this.pointerPosition) {
this.savedPointer = this.pointer
this.$refs.list.scrollTop = this.pointerPosition
}
/* istanbul ignore else */
Expand Down Expand Up @@ -130,8 +135,19 @@ export default {
}
},
pointerSet (index) {
this.pointer = index
if (this.savedPointer && this.savedPointer > 0) {
this.pointer = this.savedPointer
} else {
this.pointer = index
}

if (this.savedPointer === 0) {
this.$nextTick(() => {
this.pointer = 0
})
}
this.pointerDirty = true
this.savedPointer = null
}
}
}