Update logo in README and fix package version parameter in publish workflow#43
Merged
Conversation
shibayan
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes small documentation and release workflow adjustments for OpenApiWeaver: it updates the README logo asset to a PNG and tweaks the NuGet publish workflow’s MSBuild property used for versioning during packing.
Changes:
- Update
README.mdto reference a PNG logo instead of the SVG. - Add
docs/public/logo.pngto the docs/public assets. - Update the NuGet publish workflow to pass
-p:Version=...duringdotnet pack.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Switches the README logo reference from SVG to PNG. |
| docs/public/logo.png | Adds the PNG logo asset used by the README. |
| .github/workflows/publish.yml | Updates the MSBuild property passed to dotnet pack for versioning. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes minor updates to improve project documentation and corrects a property used in the build workflow.
Documentation update:
README.mdfrom an SVG to a PNG to improve compatibility or display.Build workflow correction:
.github/workflows/publish.yml, updated the property passed to the build command fromPackageVersiontoVersionfor consistency with expected parameters.