Skip to content

Sync some missing entries; fix some typos; etc.#126

Merged
netcode merged 1 commit intoshieldfy:masterfrom
Maikuolan:patch-1
Sep 30, 2019
Merged

Sync some missing entries; fix some typos; etc.#126
netcode merged 1 commit intoshieldfy:masterfrom
Maikuolan:patch-1

Conversation

@Maikuolan
Copy link
Copy Markdown
Collaborator

Syncs some missing entries (not all translated yet, but all language versions should at least all have the same entries now):

  • "Do not forget to turn the DEBUG mode OFF." (README-ja.md). I've tried to translate it (I'm somewhat confident in it, but checking/reviewing it is still invited).
  • "If you are parsing XML files, make sure entity expansion is not enabled to avoid Billion Laughs/XML bomb via exponential entity expansion attack." (README-lo.md and README-pl.md). I haven't tried to translate those entries though (I have zero confidence in my ability to translate Lao or Polish; better to either leave it be, or let someone else try to translate those entries, I think).
  • "Feel free to contribute by forking this repository ..." etc (README-pl.md). Also haven't tried to translate that.

Fixes some typos:

  • Some sentences missing full stops (README-id.md, README-ja.md, README-lo.md, README-mk.md, README-vi.md, README-zh.md).
  • multipart/form-data ,application/json -> multipart/form-data, application/json (README-id.md, README-lo.md, README-nl.md).
  • id -> ID (README-id.md, README-lo.md, README-th.md)
  • etc -> ໆລໆ (README-lo.md). (Based on examples already in the file).
  • e.g. -> п.р. (README-mk.md). (Based on examples already in the file).
  • e.g. -> b.v. (README-nl.md). (bijvoorbeeld...).

The etc part:

  • Slightly rewords one of the original English entries (not a typo fix; just to try to improve it a little).
  • Normalises some spacing (README-lo.md).

@Maikuolan
Copy link
Copy Markdown
Collaborator Author

(Review requested).

@Maikuolan Maikuolan requested a review from netcode July 18, 2019 15:34
@netcode netcode merged commit bba6366 into shieldfy:master Sep 30, 2019
@netcode
Copy link
Copy Markdown
Member

netcode commented Sep 30, 2019

Thanks, merged

@Maikuolan Maikuolan deleted the patch-1 branch September 30, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants