Skip to content

Update README.md#130

Merged
Maikuolan merged 1 commit intoshieldfy:masterfrom
citybasebrooks:patch-1
Dec 24, 2020
Merged

Update README.md#130
Maikuolan merged 1 commit intoshieldfy:masterfrom
citybasebrooks:patch-1

Conversation

@citybasebrooks
Copy link
Copy Markdown
Contributor

Non-public APIs should default deny access, and only permit access from whitelisted hosts.

Copy link
Copy Markdown
Collaborator

@Maikuolan Maikuolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @citybasebrooks,

LGTM! Thanks for the contribution. 👍 😊

Putting my approval on it, but before merging this.. any comments/thoughts from others..? (@netcode..?)

(I ask because, although I have push/pull/merge rights at this repository, I am not the repository owner, so I should ask first, before accepting new additions to the main list). :-)

Kind regards,
Caleb M / Maikuolan.

@netcode
Copy link
Copy Markdown
Member

netcode commented May 10, 2020

LGTM too.
I'm just too cautious about new additions, because i don't want the other translations to be outdated.

@Maikuolan Maikuolan merged commit 575745c into shieldfy:master Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants