Conversation
Due to confusing WorkerUpdate struct usage, failed tasks were being `FAILED`, then subsequently `STOPPED`, to set the time of job completion. `STOPPED` also sets status to `done`. `FAILED` already sets the completion time to now. The `FAILED` op has been updated to be more explicit about setting completion time, and moved to the end of the worker runloop, so you either have success, or failure. Additionally, archives were not being invalidated, as the logic for that would only be triggered if the creation of an archive in the database failed. This has been addressed to happen only if the archive database record was successfully created. Fixes #79
If a restore key was not parsed/detected by the worker, the task is now failed, and no archive record is created in the database. Additionally, the database is now updated to refuse to allow archives without restore keys. Fixes #55
The agent was improperly returning a hard-coded exit status to the worker. We now grab the actual exit status from the shield-pipe process that was run, or signal, if it exited with a signal, and send that back to the worker, formatted as big-endian, for the SSH server to decode. Fixes #88
Contributor
Author
|
Tested on bosh-lite with a shield-pipe that succeeds, a shield-pipe that sigterms itself, and a shield-pipe that exits normally with rc=3. |
jhunt
added a commit
that referenced
this pull request
Feb 4, 2016
Fix return codes sent from agent to worker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.