add an all events feed #797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes shift-org#116 tweaks the existing ical header for the pedalp endpoint by giving it a new friendly name and description, while keeping its global unique id as `shift@shift2bikes.org` ``` X-WR-CALNAME:Pedalpalooza Bike Calendar X-WR-CALDESC:Find fun Pedalpalooza bike events! X-WR-RELCALID:shift@shift2bikes.org ``` adds a new header use for all other ical feeds ( including single event download ) ``` X-WR-CALNAME:Shift Community Calendar X-WR-CALDESC:Find fun bike events all year round. X-WR-RELCALID:community@shift2bikes.org ``` exposes an end point which covers "all events" ( 1 month in the past and 6 months in the future at ): `/cal/shift-calendar.php' ( which maps to node at `/api/shift-calendar.php` )
- when returning the pedalpalooza feed, adds a special all day end of festival event on the day *after* pedalpalooza - changes the start and end date objects into dayjs to simplify the end event ( was raw query strings, which seems bad practice anyway ) - moves "escapeBreak" and ical date formatting to a nunjucks filter to make that code easier to reuse ( for the end event ) - changes a (start || end) to (start && end) in getEventData to avoid an exception if one is null/false; we don't have to be so clever about validating the parameters; it's only the webclient anyway.
carrythebanner
approved these changes
Aug 30, 2024
Collaborator
carrythebanner
left a comment
carrythebanner
left a comment
There was a problem hiding this comment.
Looks good! Could also add the cal feed banner to the /calgrid page, and could probably hide it on individual ride listings, but (once the minor merge conflicts are resolved) I'm good to merge this either way.
With 2 promo banners stacked there's a bit much in terms of top matter, but we'll be hiding the PP promo banner in 2 days so that's a non-issue IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #116 by exposing a new endpoint which covers "all events" ( 1 month in the past and 6 months in the future at ):
/cal/shift-calendar.php( which maps into node at/api/shift-calendar.phpwith no query parameters ) and adds a banner to the /calendar page describing the new feed ( see below ); and updates the FAQ to describe both calendars.note: this changes the existing ical header for the pedalp endpoint by giving it a new friendly name and description, while keeping its global unique id set to
shift@shift2bikes.orgwas:
now:
it uses the following ical header for the all events feed, and for any individually downloaded events: