Add MinIO storage profile command by dkocher · Pull Request #323 · shift7-ch/katta-clientlib

dkocher · 2026-03-30T11:35:53Z

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

admin-cli/src/main/java/cloud/katta/cli/commands/storage/minio/MinIOSTSStorage.java

.../src/main/java/cloud/katta/cli/commands/hub/storageprofile/minio/MinIOSTSStorageProfile.java

chenkins

Add coverage for new command.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

admin-cli/src/main/java/cloud/katta/cli/commands/storage/minio/MinIOSTSStorage.java:65

--accessbucketPolicyName (and the backing field accessbucketPolicyName) uses inconsistent casing compared to --createBucketPolicyName. For consistency and discoverability in CLI help, rename to --accessBucketPolicyName/accessBucketPolicyName. If the old flag was ever released, consider keeping --accessbucketPolicyName as an additional alias to avoid breaking existing scripts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

admin-cli/README.md

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 7 comments.

Comments suppressed due to low confidence (1)

admin-cli/src/main/java/cloud/katta/cli/commands/storage/minio/MinIOSTSStorage.java:65

The option was renamed from --createbucketPolicyName to --createBucketPolicyName, which is a breaking CLI change for existing scripts. Consider accepting both spellings (aliases) for backward compatibility, and also align the casing of --accessbucketPolicyName (e.g., add --accessBucketPolicyName) for consistency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

admin-cli/src/main/java/cloud/katta/cli/commands/AbstractAuthorizationCode.java

admin-cli/README.md

...cli/src/main/java/cloud/katta/cli/commands/hub/storageprofile/s3/S3StaticStorageProfile.java

.../src/main/java/cloud/katta/cli/commands/hub/storageprofile/minio/MinIOSTSStorageProfile.java

admin-cli/src/test/java/cloud/katta/examples/Terraform.java

...src/test/java/cloud/katta/cli/commands/hub/storageprofile/s3/S3StaticStorageProfileTest.java

.../test/java/cloud/katta/cli/commands/hub/storageprofile/minio/MinIOSTSStorageProfileTest.java

.../src/main/java/cloud/katta/cli/commands/hub/storageprofile/minio/MinIOSTSStorageProfile.java

chenkins

Fix MinIO.

Co-authored-by: Christian Eichenberger <christianmarkus@oakmountain.ch>

…lient (cryptomator for client vs. cryptomatorhub for web)

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-07T13:29:08Z

admin-cli/src/main/java/cloud/katta/cli/commands/AbstractAuthorizationCode.java

+                try (HttpClient client = HttpClient.newHttpClient()) {
+                    var response = client.send(request, HttpResponse.BodyHandlers.ofString());
+                    if(response.statusCode() != 200) {
+                        throw new IOException("Failed to fetch config from %s/api/config. HTTP status: %d".formatted(hubUrl, response.statusCode()));
+                    }
+                    var rootNode = new ObjectMapper().reader().readTree(response.body());
+                    this.tokenUrl = rootNode.get("keycloakTokenEndpoint").asText();
+                    this.authUrl = rootNode.get("keycloakAuthEndpoint").asText();
+                }


HttpClient does not implement AutoCloseable, so try (HttpClient client = HttpClient.newHttpClient()) { ... } will not compile. Create the client without try-with-resources (or reuse a static client) and keep the try-with-resources only for resources that actually need closing.

Suggested change

try (HttpClient client = HttpClient.newHttpClient()) {

var response = client.send(request, HttpResponse.BodyHandlers.ofString());

if(response.statusCode() != 200) {

throw new IOException("Failed to fetch config from %s/api/config. HTTP status: %d".formatted(hubUrl, response.statusCode()));

}

var rootNode = new ObjectMapper().reader().readTree(response.body());

this.tokenUrl = rootNode.get("keycloakTokenEndpoint").asText();

this.authUrl = rootNode.get("keycloakAuthEndpoint").asText();

}

HttpClient client = HttpClient.newHttpClient();

var response = client.send(request, HttpResponse.BodyHandlers.ofString());

if(response.statusCode() != 200) {

throw new IOException("Failed to fetch config from %s/api/config. HTTP status: %d".formatted(hubUrl, response.statusCode()));

}

var rootNode = new ObjectMapper().reader().readTree(response.body());

this.tokenUrl = rootNode.get("keycloakTokenEndpoint").asText();

this.authUrl = rootNode.get("keycloakAuthEndpoint").asText();

Copilot · 2026-04-07T13:29:09Z

admin-cli/src/main/java/cloud/katta/cli/commands/AbstractAuthorizationCode.java

+                    var rootNode = new ObjectMapper().reader().readTree(response.body());
+                    this.tokenUrl = rootNode.get("keycloakTokenEndpoint").asText();
+                    this.authUrl = rootNode.get("keycloakAuthEndpoint").asText();
+                }


rootNode.get("keycloakTokenEndpoint") / get("keycloakAuthEndpoint") can return null if the config response is missing those fields, leading to an NPE on .asText(). Use path(...) and validate non-empty values (or throw a clear exception) before proceeding.

Copilot · 2026-04-07T13:29:09Z

admin-cli/src/main/java/cloud/katta/cli/commands/AbstractAuthorizationCode.java

+                        try {
+                            Desktop.getDesktop().browse(uri);
+                        }
+                        catch(IOException e) {
+                            // Ignore
+                        }


Calling Desktop.getDesktop().browse(uri) can throw HeadlessException / UnsupportedOperationException (e.g., on servers/CI or minimal JREs). Guard with Desktop.isDesktopSupported() and catch broader runtime failures so the login flow doesn't crash in headless environments.

Suggested change

try {

Desktop.getDesktop().browse(uri);

}

catch(IOException e) {

// Ignore

}

if(Desktop.isDesktopSupported()) {

try {

var desktop = Desktop.getDesktop();

if(desktop.isSupported(Desktop.Action.BROWSE)) {

desktop.browse(uri);

}

}

catch(IOException | RuntimeException e) {

// Ignore

}

}

Copilot · 2026-04-07T13:29:09Z

admin-cli/src/main/java/cloud/katta/cli/commands/hub/storageprofile/AbstractStorageProfile.java

        final ApiClient apiClient = new ApiClient();
        apiClient.setBasePath(hubUrl);


--hubUrl is no longer required (inherited from AbstractAuthorizationCode), but this command unconditionally uses hubUrl to build the API client base path. If the user supplies --accessToken without --hubUrl, this will fail at runtime. Consider making --hubUrl required for this command, or add an explicit validation with a clear error before calling the API.

Suggested change

final ApiClient apiClient = new ApiClient();

apiClient.setBasePath(hubUrl);

if (this.hubUrl == null || this.hubUrl.isBlank()) {

throw new CommandLine.ParameterException(

new CommandLine(this),

"Missing required option: '--hubUrl'. This command requires a hub URL to build the API client."

);

}

final ApiClient apiClient = new ApiClient();

apiClient.setBasePath(this.hubUrl);

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-07T20:27:19Z

admin-cli/src/main/java/cloud/katta/cli/commands/hub/storageprofile/AbstractStorageProfile.java

    public Void call() throws Exception {
        final ApiClient apiClient = new ApiClient();
        apiClient.setBasePath(hubUrl);
        apiClient.addDefaultHeader("Authorization", "Bearer %s".formatted(this.login()));
-        this.call(new StorageProfileResourceApi(apiClient));
+        apiClient.setDebugging(debug);
+        final StorageProfileDto response = this.call(new StorageProfileResourceApi(apiClient));
+        System.out.println(new JSON().getContext(null).writeValueAsString(response));


--hubUrl is now declared in AbstractAuthorizationCode with required = false, but this command always calls apiClient.setBasePath(hubUrl). If the user provides --accessToken (so login() succeeds) but omits --hubUrl, this will fail at runtime. Please make --hubUrl required for storage profile commands (or add an explicit validation in call() before using it).

Copilot · 2026-04-07T20:27:19Z

admin-cli/src/main/java/cloud/katta/cli/commands/hub/storageprofile/ArchiveStorageProfile.java

 public class ArchiveStorageProfile extends AbstractAuthorizationCode implements Callable<Void> {
-    @CommandLine.Option(names = {"--hubUrl"}, description = "Hub URL. Example: \"https://hub.testing.katta.cloud\"", required = true)
-    String hubUrl;
-
-    @CommandLine.Option(names = {"--uuid"}, description = "The uuid.", required = true)
+    @CommandLine.Option(names = {"--uuid"}, description = "Storage Profile.", required = true)
    String uuid;


--hubUrl option was removed from this command, but the implementation still uses hubUrl (inherited from AbstractAuthorizationCode). Since --hubUrl is currently required = false in the superclass, it’s now possible to invoke storageprofile archive without providing a hub URL (especially when --accessToken is used), which will fail at runtime. Consider enforcing --hubUrl as required for this command (or validating it before apiClient.setBasePath(hubUrl)).

Copilot · 2026-04-07T20:27:19Z

...src/test/java/cloud/katta/cli/commands/hub/storageprofile/s3/S3StaticStorageProfileTest.java

+    public void testCall() throws ApiException {
+        final StorageProfileResourceApi api = Mockito.mock(StorageProfileResourceApi.class);
+        final UUID vaultId = UUID.randomUUID();
+        final S3StaticStorageProfile cli = new S3StaticStorageProfile(vaultId.toString(), vaultId.toString(), "S3 static", "us-east-1", null,


In this unit test, the first constructor argument is hubUrl, but a random UUID string is passed instead. Even if it’s currently unused by call(api), it makes the test harder to understand and could break if the implementation starts relying on hubUrl. Prefer passing a realistic URL (or use the no-arg constructor and set fields explicitly).

Suggested change

final S3StaticStorageProfile cli = new S3StaticStorageProfile(vaultId.toString(), vaultId.toString(), "S3 static", "us-east-1", null,

final S3StaticStorageProfile cli = new S3StaticStorageProfile("https://hub.example.com", vaultId.toString(), "S3 static", "us-east-1", null,

dkocher added this to the 1.0.0 milestone Mar 30, 2026

dkocher requested a review from chenkins March 30, 2026 11:35

dkocher added the cli label Mar 30, 2026

Copilot AI review requested due to automatic review settings March 30, 2026 11:35

Copilot started reviewing on behalf of dkocher March 30, 2026 11:36 View session

dkocher mentioned this pull request Mar 30, 2026

Add MinIO storage profile command #317

Closed

3 tasks

This comment was marked as outdated.

Sign in to view

Copilot AI review requested due to automatic review settings April 1, 2026 20:49

dkocher force-pushed the issues/322 branch from 1e31456 to 2383c05 Compare April 1, 2026 20:49

Copilot started reviewing on behalf of dkocher April 1, 2026 20:50 View session

This comment was marked as outdated.

Sign in to view

dkocher requested review from Copilot and ylangisc April 2, 2026 06:50

Copilot started reviewing on behalf of dkocher April 2, 2026 06:59 View session

Copilot AI reviewed Apr 2, 2026

View reviewed changes

admin-cli/src/main/java/cloud/katta/cli/commands/storage/minio/MinIOSTSStorage.java Show resolved Hide resolved

.../src/main/java/cloud/katta/cli/commands/hub/storageprofile/minio/MinIOSTSStorageProfile.java Outdated Show resolved Hide resolved

chenkins requested changes Apr 2, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings April 2, 2026 07:49

Copilot started reviewing on behalf of dkocher April 2, 2026 07:49 View session

dkocher force-pushed the issues/322 branch from 78bb9f9 to 2fefbd6 Compare April 2, 2026 07:49

dkocher enabled auto-merge April 2, 2026 07:52

dkocher requested a review from chenkins April 2, 2026 07:52

Copilot AI reviewed Apr 2, 2026

View reviewed changes

admin-cli/README.md Show resolved Hide resolved

chenkins approved these changes Apr 2, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings April 3, 2026 09:05

Copilot started reviewing on behalf of dkocher April 3, 2026 09:06 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

chenkins reviewed Apr 3, 2026

View reviewed changes

.../src/main/java/cloud/katta/cli/commands/hub/storageprofile/minio/MinIOSTSStorageProfile.java Outdated Show resolved Hide resolved

chenkins requested changes Apr 3, 2026

View reviewed changes

dkocher disabled auto-merge April 3, 2026 09:39

Copilot AI review requested due to automatic review settings April 3, 2026 09:53

dkocher and others added 19 commits April 7, 2026 15:21

Remove deprecated annoation.

09088a4

Consistent naming.

2c4385c

Camel casing.

22cc4bf

Consistent naming.

d6f97d9

Add documentation.

74857e5

Add test coverage.

6e650c0

Add command to configure generic S3 storage profile.

760ee28

Workaround for shift7-ch/katta-server#124

2805b2d

Cleanup.

94e1304

Co-authored-by: Christian Eichenberger <christianmarkus@oakmountain.ch>

Add documentation.

eeb2cb6

Add sample.

b7e5d33

Update documentation for commands.

ef74f46

Update sample only requiring --hubUrl.

e90981e

Delete redundant assertions.

b6e16d9

Read Keycloak endpoints from public configuration.

5c7e6b1

Print JSON response.

7d6f9eb

Add admin cli example for local dev setup.

289809e

MinIO has a simpler model than AWS and requires different roles per c…

6a533c2

…lient (cryptomator for client vs. cryptomatorhub for web)

Delete redundant assertions.

161d87c

dkocher force-pushed the issues/322 branch from 79f7f58 to 161d87c Compare April 7, 2026 13:21

dkocher added 2 commits April 7, 2026 15:22

Attempt to open browser with authorization URL.

9d123bf

Camel casing.

a003f54

Copilot AI review requested due to automatic review settings April 7, 2026 13:23

Copilot started reviewing on behalf of dkocher April 7, 2026 13:24 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

dkocher added 2 commits April 7, 2026 15:51

Add guard.

196b941

Add --debug flag to print HTTP request & response.

6873960

Copilot AI review requested due to automatic review settings April 7, 2026 20:22

Copilot started reviewing on behalf of dkocher April 7, 2026 20:23 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

-                        try {
-                            Desktop.getDesktop().browse(uri);
-                        }
-                        catch(IOException e) {
-                            // Ignore
-                        }
+                        if(Desktop.isDesktopSupported()) {
+                            try {
+                                var desktop = Desktop.getDesktop();
+                                if(desktop.isSupported(Desktop.Action.BROWSE)) {
+                                    desktop.browse(uri);
+                                }
+                            }
+                            catch(IOException | RuntimeException e) {
+                                // Ignore
+                            }
+                        }

		final ApiClient apiClient = new ApiClient();
		apiClient.setBasePath(hubUrl);

-        final ApiClient apiClient = new ApiClient();
-        apiClient.setBasePath(hubUrl);
+        if (this.hubUrl == null || this.hubUrl.isBlank()) {
+            throw new CommandLine.ParameterException(
+                new CommandLine(this),
+                "Missing required option: '--hubUrl'. This command requires a hub URL to build the API client."
+            );
+        }
+        final ApiClient apiClient = new ApiClient();
+        apiClient.setBasePath(this.hubUrl);

	final S3StaticStorageProfile cli = new S3StaticStorageProfile(vaultId.toString(), vaultId.toString(), "S3 static", "us-east-1", null,
	final S3StaticStorageProfile cli = new S3StaticStorageProfile("https://hub.example.com", vaultId.toString(), "S3 static", "us-east-1", null,

Conversation

dkocher commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

chenkins left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chenkins left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dkocher commented Mar 30, 2026 •

edited

Loading