-
Notifications
You must be signed in to change notification settings - Fork 1
Add blog posts feature #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
l0ud0gg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice man, havent run it up but looking over the template and styles makes sense. was it intentional to remove the app badges footer block for posts? i think that makes sense, we could prolly reduce it across the site a bit as its not so subtle. CSS lint is failing but otherwise lgtm.
|
I was able to run it up against staging-store-kibble. looks good. I did notice the posts page height calculation is a bit wierd -seem to be able to scroll a bit past the footer, or is this the caveat with the truncation? |
|
Good catch on the footer issue -- not 100% sure why the max-heighted overflow was making the body longer, but overflow: hidden on the |
i forgot i put that in as an experiment; i felt they were distracting and not really relevant to the post / feed because it appeared right below it, but maybe the real issue is that they're a bit obnoxious in our default template and we should try to do a better job of pushing people to apps at a relevant part of the journey? |
yeah totally agree to both points. can prolly leave out of posts anyways |
Description of work
Add support for blog pages and a chronological feed.
The feed (
/posts/) is rendered as a separate kibble.json route using the PageIndex, filtered to posts and chronologically sorted by the page's published date. It uses Kibble's pagination.The header image is used in the post feed / page; but in future it'd be nice to have other features in that 'slot' -- a media item 'embed' (or at least a link to the page), or something else.
It might be nice to add some shortcode templates too for embedding media, e.g.
{{poster slug=/film/123 cta=true orientation=portrait size=lg}}to make it more useful for posts to feature content from the site. OTOH, shortcodes are very problematic for native app support / future email notification features -- so maybe not the best idea.Edge cases/Caveats/Known issues
<!--more-->comment like Wordpress etc. do to indicate a good place for the fold. This will need some careful refactoring of the way Markdown fields in Kibble are handled though, as currently the Description/Content is replaced with rendered + sanitised HTML before the Jet runs/page/whatever/) due to limitations with Kibble's routeTo functionChecklist