Skip to content

Conversation

@stephenfin
Copy link
Contributor

@stephenfin stephenfin commented Jan 22, 2026

A future change will remove the Makefile once our CI has been switched over.

@stephenfin
Copy link
Contributor Author

/assign @mandre
/assign @eshulman2

@stephenfin
Copy link
Contributor Author

We can expect those jobs to fail until openshift/release#73878 merges.

@stephenfin stephenfin changed the title Use tox for testing OSASINFRA-4096: Use tox for testing Jan 23, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 23, 2026

@stephenfin: This pull request references OSASINFRA-4096 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

A future change will remove the Makefile once our CI has been switched over.

Depends on openshift/release#73878

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stephenfin
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 23, 2026

@stephenfin: This pull request references OSASINFRA-4096 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

A future change will remove the Makefile once our CI has been switched
over.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@stephenfin stephenfin changed the title OSASINFRA-4096: Use tox for testing OSASINFRA-4096: Add tox configuration Jan 23, 2026
@stephenfin
Copy link
Contributor Author

/unhold

This is purely additive now. Removing the Makefile and related files can be done in a follow-up.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 23, 2026

@stephenfin: This pull request references OSASINFRA-4096 which is a valid jira issue.

Details

In response to this:

A future change will remove the Makefile once our CI has been switched over.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jan 23, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 83db236 into main Jan 23, 2026
4 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the tox branch January 23, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants