Skip to content

Replace B1+ maps by ones that can be opened in FSLeyes#19

Merged
gaspardcereza merged 3 commits intomasterfrom
gc/b1_FSLeyes
Feb 22, 2022
Merged

Replace B1+ maps by ones that can be opened in FSLeyes#19
gaspardcereza merged 3 commits intomasterfrom
gc/b1_FSLeyes

Conversation

@gaspardcereza
Copy link
Copy Markdown
Member

Working on the GUI, I realized that it was really bothering me not being able to open the B1+ maps into FSLeyes before doing the shimming.

Reminder: They cannot be opened because Siemens did not provide any DICOM tags that enables dcm2niix to identify which image corresponds to which Tx element, to the images end up completely shuffled in the NIfTI file.

I thus decided to move the unshuffling/rescaling of the B1+ maps right after the conversion instead of when loading the NIfTI with read_nii. This way, they can be opened at any time by the user in FSLeyes.

I did all the necessary changes on this branch (don't pay attention to the name of the branch, I started by doing something entirely different). I just want to update the testing process to take these changes into account and, to do so, I need to update the testing data so that they correspond to the new repaired NIfTI files instead of the old bogus ones.

Copy link
Copy Markdown
Member

@po09i po09i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice you have now files here: data-testing/tmp_dcm2bids/helper/053_tmp_standard_tra_20210928093219.nii.gz. I would have thought they would be inside the ds_tb1 folder?

@gaspardcereza
Copy link
Copy Markdown
Member Author

gaspardcereza commented Feb 21, 2022

I notice you have now files here: data-testing/tmp_dcm2bids/helper/053_tmp_standard_tra_20210928093219.nii.gz. I would have thought they would be inside the ds_tb1 folder?

They are tmp outputs of dcm2niix (not rescaled and bogus). They haven't been processed by dcm2bids yet so they should remain in the tmp_dcm2bids folder from what I understand of how dcm2bids works. I just need them to test the function that fixes the B1+ maps.

@po09i
Copy link
Copy Markdown
Member

po09i commented Feb 21, 2022

The tmp_dcm2bids folder should be in the same folder as the sub_xxxxx folder. See here
Screen Shot 2022-02-21 at 6 10 02 PM

@gaspardcereza
Copy link
Copy Markdown
Member Author

The tmp_dcm2bids folder should be in the same folder as the sub_xxxxx folder.

You're right sorry ! I corrected that in ebdac7e

@po09i po09i self-requested a review February 22, 2022 06:02
@gaspardcereza gaspardcereza merged commit 24b7ebf into master Feb 22, 2022
@gaspardcereza gaspardcereza deleted the gc/b1_FSLeyes branch February 22, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants