float_endf from endf package #56
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Paul made this fab python endf package. It includes the
float_endffunction that we have in openmc. One key difference is that the endf package is pip installable and makes use of pybind11 to link the cpp with the python side.Removing the local
float_endfand replacing it with thefloat_endffrom this package would be really useful for making openmc pip installable. This would help avoid some of the complicated cython useage when making the wheelrelated PR for creating a conda-forge distribution for the endf package
Fixes # (issue)
Checklist