Skip to content

Conversation

@shimwell
Copy link
Owner

@shimwell shimwell commented Jul 29, 2024

Description

Paul made this fab python endf package. It includes the float_endf function that we have in openmc. One key difference is that the endf package is pip installable and makes use of pybind11 to link the cpp with the python side.

Removing the local float_endf and replacing it with the float_endf from this package would be really useful for making openmc pip installable. This would help avoid some of the complicated cython useage when making the wheel

related PR for creating a conda-forge distribution for the endf package

Fixes # (issue)

Checklist

  • I have performed a self-review of my own code
  • I have followed the style guidelines for Python source files (if applicable)

@coveralls
Copy link

coveralls commented Jul 29, 2024

Pull Request Test Coverage Report for Build 10378180263

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 160 unchanged lines in 24 files lost coverage.
  • Overall coverage decreased (-0.2%) to 84.798%

Files with Coverage Reduction New Missed Lines %
include/openmc/position.h 1 25.0%
include/openmc/endf.h 1 75.0%
include/openmc/distribution_spatial.h 1 75.0%
include/openmc/container_util.h 1 0.0%
include/openmc/material.h 1 50.0%
include/openmc/particle.h 1 0.0%
include/openmc/timer.h 1 0.0%
include/openmc/angle_energy.h 2 0.0%
include/openmc/tallies/tally.h 2 25.0%
include/openmc/openmp_interface.h 2 50.0%
Totals Coverage Status
Change from base Build 10185501209: -0.2%
Covered Lines: 49506
Relevant Lines: 58381

💛 - Coveralls

@jon-proximafusion jon-proximafusion force-pushed the replacing_endf_c_functions_with_package branch from d3efb24 to c03a236 Compare August 13, 2024 22:30
@shimwell shimwell closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants