Change canImport to DEBUG check#78
Merged
daveverwer merged 1 commit intoshinydevelopment:masterfrom Apr 9, 2019
davidrothera:master
Merged
Change canImport to DEBUG check#78daveverwer merged 1 commit intoshinydevelopment:masterfrom davidrothera:master
daveverwer merged 1 commit intoshinydevelopment:masterfrom
davidrothera:master
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In previous usage of the library I had always been using
if DEBUGhowever decided to use thecanImportinstead but this caused issues when uploading to the App Store as SimulatorStatusMagic was ending up in my framework search list.I triple checked everything and the last thing I tried was moving back to
if DEBUGwhich stopped it appearing in my framework search path (shown withotool -L).Putting this PR in to hopefully help anyone else who has this issue.