Support querying on multiple locales at once#232
Merged
Conversation
8fe9ede to
1fc9ce0
Compare
6a9c49e to
ecce62d
Compare
6be862f to
c0c04e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is currently supported (although not tested) by all backends except KeyValue and Table. Should be straightforward to support universally.
The format looks like this:
This queries for a post with an English title
Titleand a Japanese titleタイトル, but obviously you could build much more complex logic.Here is the resulting SQL for a Jsonb backend:
The problem with KeyValue and Table backends is that their respective joins do not alias the table name with an alias that includes the locale.