Skip to content

Fix handling of the void type in ForbidPhpDocNullabilityMismatchWithNativeTypehintRule #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janedbal merged 5 commits into from
Nov 27, 2025
Merged

Fix handling of the void type in ForbidPhpDocNullabilityMismatchWithNativeTypehintRule #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e7188cc
Fix handling of the `void` type in `ForbidPhpDocNullabilityMismatchWi…
mspirkov Nov 26, 2025
cd0bb09
Merge branch 'master' into fix-phpdoc-nullability-mismatch
mspirkov Nov 26, 2025
23af6c6
fix cs
mspirkov Nov 26, 2025
a14317b
fix cs
mspirkov Nov 26, 2025
e10e363
use `isVoid()`
mspirkov Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,6 @@
/cache/*
!/cache/.gitkeep
/.idea
/.vscode
/phpstan.neon
/composer.phar
2 changes: 1 addition & 1 deletion src/Rule/ForbidPhpDocNullabilityMismatchWithNativeTypehintRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ private function comparePhpDocAndNativeType(
return [];
}

if ($nativeReturnType instanceof MixedType) {
if ($nativeReturnType instanceof MixedType || $nativeReturnType->isVoid()->yes()) {
return [];
}

Expand Down
9 changes: 9 additions & 0 deletions tests/Rule/data/ForbidPhpDocNullabilityMismatchWithNativeTypehintRule/code.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace ForbidPhpDocNotMatchingNativeTypehintRule;

use Exception;

class HelloWorld
{
Expand Down Expand Up @@ -105,4 +106,12 @@ public static function getStringMissingNull($stringOrNullInTemplate): ?string //
return $stringOrNullInTemplate;
}

/**
* @return never
*/
public function throwSomeException(): void
{
throw new Exception();
}

}