Skip to content

update angular 18#2243

Merged
chuckcarpenter merged 7 commits intoshipshapecode:mainfrom
bastienmoulia:angular-18
Jun 25, 2024
Merged

update angular 18#2243
chuckcarpenter merged 7 commits intoshipshapecode:mainfrom
bastienmoulia:angular-18

Conversation

@bastienmoulia
Copy link
Copy Markdown
Contributor

Fix #2241

@phhbr
Copy link
Copy Markdown
Contributor

phhbr commented Jun 5, 2024

LGTM

@phhbr
Copy link
Copy Markdown
Contributor

phhbr commented Jun 13, 2024

Can you take a look @RobbieTheWagner? Thanks a lot 👍

@RobbieTheWagner
Copy link
Copy Markdown
Member

@bastienmoulia looks like we need to fix some CI issues with volta before we can merge this. Would you be interested in taking that on?

@bastienmoulia
Copy link
Copy Markdown
Contributor Author

@bastienmoulia looks like we need to fix some CI issues with volta before we can merge this. Would you be interested in taking that on?

I don't know what is Volta... I maybe will have some time to look at it but not sure.

@chuckcarpenter
Copy link
Copy Markdown
Member

chuckcarpenter commented Jun 21, 2024

@bastienmoulia I fixed the volta issue and tried to version lock CLI, but schematics requires a < 18 of CLI to work. I think you'll need to update that and the other eslint packages for v18. e.g., of the problem in schematics package.json

"peerDependencies": {
    "@angular/cli": ">= 17.0.0 < 18.0.0"
  },

@bastienmoulia
Copy link
Copy Markdown
Contributor Author

@bastienmoulia I fixed the volta issue and tried to version lock CLI, but schematics requires a < 18 of CLI to work. I think you'll need to update that and the other eslint packages for v18. e.g., of the problem in schematics package.json

"peerDependencies": {
    "@angular/cli": ">= 17.0.0 < 18.0.0"
  },

Done

@chuckcarpenter chuckcarpenter merged commit be45458 into shipshapecode:main Jun 25, 2024
@chuckcarpenter
Copy link
Copy Markdown
Member

@RobbieTheWagner do you just release this from your local then?

@VilleFTW
Copy link
Copy Markdown

VilleFTW commented Jul 1, 2024

Hi @RobbieTheWagner ,

Could you please do a new release with support for v18 on npm?

@pathrom
Copy link
Copy Markdown

pathrom commented Jul 9, 2024

Hi @RobbieTheWagner ,

Could you please do a new release with support for v18 on npm?

Please @RobbieTheWagner

This was referenced Jul 10, 2024
@RobbieTheWagner
Copy link
Copy Markdown
Member

It has been released now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Angular 18

6 participants