Added default fallback for target when step is hidden/destroyed#1132
Merged
RobbieTheWagner merged 2 commits intoshipshapecode:masterfrom Sep 5, 2020
Merged
Conversation
added 2 commits
September 4, 2020 22:24
…abled" class is removed from body on non-attached steps
RobbieTheWagner
approved these changes
Sep 5, 2020
Member
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1131
If a step is added without specifically specifying an element to attach to, there was a default to fallback to document.body.
When a step was hidden/destroyed, this.target was checked which in the case of a non-attached step, this.target was null.