Merged
Conversation
chuckcarpenter
approved these changes
Aug 23, 2018
Member
chuckcarpenter
left a comment
chuckcarpenter
left a comment
There was a problem hiding this comment.
Overall seems good. Just wondering if the old typeof checks should be replaced with a check for the type we're expecting.
| const once = arguments.length <= 3 || arguments[3] === undefined ? false : arguments[3]; | ||
|
|
||
| if (typeof this.bindings === 'undefined') { | ||
| if (_.isUndefined(this.bindings)) { |
Member
There was a problem hiding this comment.
Think the original intent is to check if it's an object, perhaps that one instead?
|
|
||
| off(event, handler) { | ||
| if (typeof this.bindings === 'undefined' || typeof this.bindings[event] === 'undefined') { | ||
| if (_.isUndefined(this.bindings) || _.isUndefined(this.bindings[event])) { |
Member
There was a problem hiding this comment.
same for this first statement
| for (let _key = 1; _key < _len; _key++) { | ||
| args[_key - 1] = arguments[_key]; | ||
| } | ||
| this.bindings[event].forEach((binding, index) => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.