Rename Tour.options.defaults to Tour.options.defaultStepOptions.#244
Rename Tour.options.defaults to Tour.options.defaultStepOptions.#244RobbieTheWagner merged 1 commit intomasterfrom
Tour.options.defaults to Tour.options.defaultStepOptions.#244Conversation
Corresponds to shipshapecode/shepherd#244.
RobbieTheWagner
left a comment
RobbieTheWagner
left a comment
There was a problem hiding this comment.
The defaults -> defaultStepOptions parts look good! Just one requested change on the yarn test stuff.
package.json
Outdated
| "rewrite-paths": "replace 'SF:.*src' 'SF:src' coverage/lcov.info", | ||
| "start": "yarn watch", | ||
| "start-test-server": "http-server", | ||
| "test": "cross-env NODE_ENV=test webpack --config webpack.test.config.js && yarn mocha-headless-chrome", |
There was a problem hiding this comment.
I don't know if I agree with this change. I typically run yarn test:ci as the full test suite, to run all unit and acceptance tests, so if you want a yarn test command, we should just have "test": "yarn test:ci", but I'm also not sure we need a yarn test command, since we can just use yarn test:ci. I'm okay with it though, if we make it run all the tests.
There was a problem hiding this comment.
I feel like it's useful to have a plain test command so new developers can instantly see which one is the default -- but I'm totally open to suggestions as to what it should say 😄!
My original attempt was to just run mocha-headless-chrome, but that wasn't rebuilding the code as I made changes -- so that's how I ended up with the longer set of commands. I just updated again to use yarn test:ci instead.
BrianSipple
force-pushed
the
change-tour-options-defaults
branch
from
3e54f39 to
e230ea9
Compare
BrianSipple
force-pushed
the
change-tour-options-defaults
branch
from
e230ea9 to
ac87568
Compare
Corresponds to shipshapecode/shepherd#244.
* Rename `defaults` to `defaultStepOptions`. Corresponds to shipshapecode/shepherd#244. * Update shepherd.js
2 participants
Closes #240.