Integrate modal functionality that was originally in Ember Shepherd#301
Merged
RobbieTheWagner merged 4 commits intomasterfrom Dec 31, 2018
Merged
Integrate modal functionality that was originally in Ember Shepherd#301RobbieTheWagner merged 4 commits intomasterfrom
RobbieTheWagner merged 4 commits intomasterfrom
Conversation
BrianSipple
force-pushed
the
modal-functionality
branch
2 times, most recently
from
9f529b1 to
5d8bb6d
Compare
Member
|
@BrianSipple looking good so far! We'll definitely want to port tests over as well before merging, but happy to see this functionality materializing here 😄 |
* fix: stop pull on overlap * fix: selector for overlay * update listener calls to match previous utils
RobbieTheWagner
force-pushed
the
modal-functionality
branch
from
a4bb2f0 to
ae46755
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's still a bit that needs to be added to the test coverage here, but overall, I think covers what we want to move over, @rwwagner90