Optional padding on modalOverlayOpening#383
Merged
chuckcarpenter merged 2 commits intoshipshapecode:masterfrom May 30, 2019
Merged
Optional padding on modalOverlayOpening#383chuckcarpenter merged 2 commits intoshipshapecode:masterfrom
chuckcarpenter merged 2 commits intoshipshapecode:masterfrom
Conversation
Member
|
@skmbr this LGTM! Thanks for taking the time. I'll merge and you can use from MASTER until the release is set. |
Contributor
Author
|
@chuckcarpenter Brilliant, thank you! :) When do think you'll be doing a release? |
Member
|
@skmbr I will be home tomorrow, and I can work on the next release |
1 similar comment
Member
|
@skmbr I will be home tomorrow, and I can work on the next release |
Member
|
@skmbr it appears the build is failing after merging this PR, also it would be nice to have tests and docs for this feature. Would you mind taking a look? |
Contributor
Author
|
@rwwagner90 Sorry, not had a chance to come back to this over the last few weeks. Will try and take a look next week, but not sure where to start. Can I see the errors from the build somewhere? :( |
Member
Contributor
Author
|
Oh, cool! Thanks! I shall read and learn ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relating to: #379